-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable log in button on submit #29
Conversation
Disables log in button on the submit action. User can re-enable it again by removing `disabled` attribute. Fixes #9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @DiegoCardoso)
src/vaadin-login.html, line 207 at r1 (raw file):
submit() { if (!this.disabled) { this.$.loginForm.submit();
The button becomes disabled even if the form is invalid. So actual submit didn't happen, but the button is already disabled. We could use the same logic for button click as for enter
press.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @alexberazouski)
src/vaadin-login.html, line 207 at r1 (raw file):
Previously, alexberazouski wrote…
The button becomes disabled even if the form is invalid. So actual submit didn't happen, but the button is already disabled. We could use the same logic for button click as for
enter
press.
Good catch, thanks! Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
Disables log in button on the submit action. User can re-enable it again by removing
disabled
attribute.Fixes #9
This change is